fix(tools): add skill script dir to sys.path#5885
Closed
he-yufeng wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hi @he-yufeng , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix formatting errors by running autoformat.sh |
rohityan
added
the
request clarification
he-yufeng
force-pushed
the
fix/skill-script-sys-path
branch
from
7164881 to
237c4e1
Compare
Collaborator
|
I have merged in commit 9296198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sys.pathbeforerunpy.run_pathscripts/Fixes #5882.
To verify
git diff --checkpython -m py_compile src/google/adk/tools/skill_toolset.py tests/unittests/tools/test_skill_toolset.pypython -m ruff check src/google/adk/tools/skill_toolset.py tests/unittests/tools/test_skill_toolset.pypython -m pyink --check src/google/adk/tools/skill_toolset.py tests/unittests/tools/test_skill_toolset.pyPYTHONPATH=src python -m pytest tests/unittests/tools/test_skill_toolset.py::test_execute_script_python_success tests/unittests/tools/test_skill_toolset.py::test_integration_python_imports_sibling_script_module tests/unittests/tools/test_skill_toolset.py::test_integration_python_stdout tests/unittests/tools/test_skill_toolset.py::test_integration_python_sys_exit_zero -qPYTHONPATH=src python -m pytest tests/unittests/tools/test_skill_toolset.py -k "not shell" -qI also ran the full
tests/unittests/tools/test_skill_toolset.pyfile on Windows. The Python tests passed, but three existing shell integration tests fail because this Windows environment does not havebashon PATH.