Feat: LiteLlm: Make LiteLLM file attachment failures consistent by raising explicit errors instead of silent fallback#5547
Conversation
|
Response from ADK Triaging Agent Hello @Lin-Nikaido, thank you for creating this PR! Could you please fill out the This information will help reviewers to review your PR more efficiently. Thanks! |
|
Hi @Lin-Nikaido , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @GWeale , can you please review this. |
|
Thanks for the PR. The same behavior already landed in main, where LiteLlm raises an explicit ValueError for unsupported file URIs instead of the silent text fallback (see _is_file_uri_supported and _get_content in src/google/adk/models/lite_llm.py, with matching tests in test_litellm.py), so we are closing this as already resolved. |
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed

pytestresults.Note: I observed unrelated local failures in
tests/unittests/cli/utils/test_cli_deploy.py.The failures seem to be caused by a local environment/import-path difference, not by this PR:
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Send
Hiwith fileChecklist
Additional context
Add any other context or screenshots about the feature request here.