Skip to content

fix: guard against None converter results in RemoteA2aAgent #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enjoykumawat wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −0
Open

fix: guard against None converter results in RemoteA2aAgent #5199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d26d1d
fix: guard against None converter results in RemoteA2aAgent
enjoykumawat Apr 7, 2026
8550233
Merge branch 'main' into fix/remote-a2a-agent-none-check
rohityan Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/google/adk/agents/remote_a2a_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,8 @@ async def _handle_a2a_response(
event = convert_a2a_message_to_event(
update.status.message, self.name, ctx, self._a2a_part_converter
)
if not event:
return None
if event.content is not None and update.status.state in (
TaskState.submitted,
TaskState.working,
Expand All @@ -501,6 +503,8 @@ async def _handle_a2a_response(
# for now.
return None

if not event:
return None
event.custom_metadata = event.custom_metadata or {}
event.custom_metadata[A2A_METADATA_PREFIX + "task_id"] = task.id
if task.context_id:
Expand All @@ -513,6 +517,8 @@ async def _handle_a2a_response(
event = convert_a2a_message_to_event(
a2a_response, self.name, ctx, self._a2a_part_converter
)
if not event:
return None
event.custom_metadata = event.custom_metadata or {}

if a2a_response.context_id:
Expand Down Expand Up @@ -583,6 +589,8 @@ async def _handle_a2a_response_v2(
event = self._config.a2a_message_converter(
a2a_response, self.name, ctx, self._config.a2a_part_converter
)
if not event:
return None
event.custom_metadata = event.custom_metadata or {}

if a2a_response.context_id:
Expand Down
Loading