Conversation
Summary of ChangesHello @jayy-77, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the type annotation parsing capabilities of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @jayy-77, thank you for creating this PR! Could you please fill out the "Testing Plan" section in your PR description to describe how you tested your changes? This information will help reviewers to review your PR more efficiently. Thanks! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the new | union type syntax from Python 3.10, which is a valuable enhancement. The implementation correctly identifies the places where typing.Union is checked and adds types.UnionType for the new syntax. However, the current approach introduces a backward compatibility issue, as it will cause an AttributeError on Python versions older than 3.10. My review includes suggestions to fix this by using getattr for safe access to types.UnionType, ensuring the library remains compatible with older Python versions.
| return schema | ||
| if ( | ||
| get_origin(param.annotation) is Union | ||
| get_origin(param.annotation) in (Union, typing_types.UnionType) |
There was a problem hiding this comment.
This check will raise an AttributeError on Python versions below 3.10, as types.UnionType was introduced in Python 3.10. To ensure backward compatibility, it's safer to access UnionType using getattr with a default value that won't be matched.
| get_origin(param.annotation) in (Union, typing_types.UnionType) | |
| get_origin(param.annotation) in (Union, getattr(typing_types, 'UnionType', object())) |
| _raise_if_schema_unsupported(variant, schema) | ||
| return schema | ||
| if origin is Union: | ||
| if origin in (Union, typing_types.UnionType): |
There was a problem hiding this comment.
This check will raise an AttributeError on Python versions below 3.10, as types.UnionType was introduced in Python 3.10. To ensure backward compatibility, it's safer to access UnionType using getattr with a default value that won't be matched.
| if origin in (Union, typing_types.UnionType): | |
| if origin in (Union, getattr(typing_types, 'UnionType', object())): |
|
|
||
| # Get the actual type T of the parameter if it's Optional[T] | ||
| if get_origin(param_type) is Union: | ||
| if get_origin(param_type) in (Union, typing_types.UnionType): |
There was a problem hiding this comment.
This check will raise an AttributeError on Python versions below 3.10, as types.UnionType was introduced in Python 3.10. To ensure backward compatibility, it's safer to access UnionType using getattr with a default value that won't be matched.
| if get_origin(param_type) in (Union, typing_types.UnionType): | |
| if get_origin(param_type) in (Union, getattr(typing_types, 'UnionType', object())): |
|
|
||
| # Handle Optional[PydanticModel] types | ||
| if get_origin(param.annotation) is Union: | ||
| if get_origin(param.annotation) in (Union, typing_types.UnionType): |
There was a problem hiding this comment.
This check will raise an AttributeError on Python versions below 3.10, as types.UnionType was introduced in Python 3.10. To ensure backward compatibility, it's safer to access UnionType using getattr with a default value that won't be matched.
| if get_origin(param.annotation) in (Union, typing_types.UnionType): | |
| if get_origin(param.annotation) in (Union, getattr(typing_types, 'UnionType', object())): |
2 participants
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
#4371
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.