chore: check for existing release instead of manifest version#60
Merged
Jacksunwei merged 1 commit intomainfrom Feb 7, 2026
Merged
chore: check for existing release instead of manifest version#60Jacksunwei merged 1 commit intomainfrom
Jacksunwei merged 1 commit intomainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Check if a GitHub release already exists for the version instead of checking the manifest version.
Why
The previous manifest check would skip release-please after the changelog PR is merged (because manifest is updated to target version), preventing draft release creation.
Change
if manifest_version == target_version: skipif release v{version} exists: skip