Changes for go deployment on agent engine.#1681
Conversation
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Stale Python-only tag in The page header still marks this as Python-only: <div class="language-support-tag" title="Agent Runtime currently supports only Python.">
<span class="lst-supported">Supported in ADK</span><span class="lst-python">Python</span>
</div>Both the <div class="language-support-tag" title="Agent Runtime supports Python and Go.">
<span class="lst-supported">Supported in ADK</span><span class="lst-python">Python</span><span class="lst-go">Go</span>
</div>(Exact tag name for Go should match whatever convention the rest of the docs site uses for language tags.) |
koverholt
left a comment
There was a problem hiding this comment.
Thanks for the PR and additions!
- Let us know when this PR is out of draft state and ready for docs review.
- There is a problem with the committers in this PR that is causing the CI check to fail. Since this PR was co-authored by GitHub Copilot, it will not be possible to pass the CLA CI check. You will need to either amend the commit to remove the Copilot coauthor, or open a new PR without that coauthor.
Fixed |
fa2dde9 to
b4b52dc
Compare
About the copilot: I have removed it from commits |
|
Two gaps in the Go section worth addressing before merge: The Also |
Added a section explaining the flags. But maybe it makes sense to have separate pages for CLI
|
|
Please look at the new file "methods.md". It's not final, but in my opinion such an approach will allow end users to use ADK deployed on AgentEngine easier. For me, I had a lot of friction due to not specified inputs , outputs, error handling and misleading overrides done by aiplatform. |
karolpiotrowicz
left a comment
There was a problem hiding this comment.
A few issues to fix before merging — mostly in the new methods.md file.
8afbd96 to
08d7701
Compare
08d7701 to
58a3d5a
Compare
|
I have removed "methods.md". Please review |
Added information about the deployment of a golang agent to Agent Engine