Skip to content

Changes for go deployment on agent engine.#1681

Open
kdroste-google wants to merge 2 commits into
google:mainfrom
kdroste-google:goAgentEngine
Open

Changes for go deployment on agent engine.#1681
kdroste-google wants to merge 2 commits into
google:mainfrom
kdroste-google:goAgentEngine

Conversation

@kdroste-google
Copy link
Copy Markdown
Collaborator

Added information about the deployment of a golang agent to Agent Engine

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for adk-docs-preview ready!

Name Link
🔨 Latest commit b9c6e4d
🔍 Latest deploy log https://app.netlify.com/projects/adk-docs-preview/deploys/6a0d651a152163000899662a
😎 Deploy Preview https://deploy-preview-1681--adk-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 24, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Comment thread docs/deploy/agent-runtime/deploy.md
@karolpiotrowicz
Copy link
Copy Markdown
Collaborator

Stale Python-only tag in docs/deploy/agent-runtime/deploy.md (lines 3–4)

The page header still marks this as Python-only:

<div class="language-support-tag" title="Agent Runtime currently supports only Python.">
    <span class="lst-supported">Supported in ADK</span><span class="lst-python">Python</span>
</div>

Both the title attribute and the <span class="lst-python"> need to be updated to reflect Go support. For example:

<div class="language-support-tag" title="Agent Runtime supports Python and Go.">
    <span class="lst-supported">Supported in ADK</span><span class="lst-python">Python</span><span class="lst-go">Go</span>
</div>

(Exact tag name for Go should match whatever convention the rest of the docs site uses for language tags.)

Copy link
Copy Markdown
Collaborator

@koverholt koverholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and additions!

  1. Let us know when this PR is out of draft state and ready for docs review.
  2. There is a problem with the committers in this PR that is causing the CI check to fail. Since this PR was co-authored by GitHub Copilot, it will not be possible to pass the CLA CI check. You will need to either amend the commit to remove the Copilot coauthor, or open a new PR without that coauthor.

Comment thread docs/deploy/agent-runtime/deploy.md Outdated
Comment thread docs/deploy/agent-runtime/deploy.md Outdated
@kdroste-google
Copy link
Copy Markdown
Collaborator Author

Stale Python-only tag in docs/deploy/agent-runtime/deploy.md (lines 3–4)

The page header still marks this as Python-only:

<div class="language-support-tag" title="Agent Runtime currently supports only Python.">
    <span class="lst-supported">Supported in ADK</span><span class="lst-python">Python</span>
</div>

Both the title attribute and the <span class="lst-python"> need to be updated to reflect Go support. For example:

<div class="language-support-tag" title="Agent Runtime supports Python and Go.">
    <span class="lst-supported">Supported in ADK</span><span class="lst-python">Python</span><span class="lst-go">Go</span>
</div>

(Exact tag name for Go should match whatever convention the rest of the docs site uses for language tags.)

Fixed

@kdroste-google
Copy link
Copy Markdown
Collaborator Author

Thanks for the PR and additions!

  1. Let us know when this PR is out of draft state and ready for docs review.
  2. There is a problem with the committers in this PR that is causing the CI check to fail. Since this PR was co-authored by GitHub Copilot, it will not be possible to pass the CLA CI check. You will need to either amend the commit to remove the Copilot coauthor, or open a new PR without that coauthor.

About the copilot: I have removed it from commits

@desiorac
Copy link
Copy Markdown

Two gaps in the Go section worth addressing before merge:

The adkgo deploy agentengine flags (-e, -s, -p, -r, -d) aren't documented inline or linked to a CLI reference. The Python section links to [ADK CLI Reference](/api-reference/cli/#adk-deploy-agent-engine) — Go needs an equivalent.

Also index.md: "Agent Runtime has it's own API" — should be "its".

@kdroste-google
Copy link
Copy Markdown
Collaborator Author

Two gaps in the Go section worth addressing before merge:

The adkgo deploy agentengine flags (-e, -s, -p, -r, -d) aren't documented inline or linked to a CLI reference. The Python section links to [ADK CLI Reference](/api-reference/cli/#adk-deploy-agent-engine) — Go needs an equivalent.

Added a section explaining the flags. But maybe it makes sense to have separate pages for CLI

Also index.md: "Agent Runtime has it's own API" — should be "its".
Fixed, thanks!

@kdroste-google kdroste-google marked this pull request as ready for review April 30, 2026 15:41
@kdroste-google
Copy link
Copy Markdown
Collaborator Author

Please look at the new file "methods.md". It's not final, but in my opinion such an approach will allow end users to use ADK deployed on AgentEngine easier. For me, I had a lot of friction due to not specified inputs , outputs, error handling and misleading overrides done by aiplatform.

Copy link
Copy Markdown
Collaborator

@karolpiotrowicz karolpiotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link
Copy Markdown
Collaborator

@karolpiotrowicz karolpiotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link
Copy Markdown
Collaborator

@karolpiotrowicz karolpiotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link
Copy Markdown
Collaborator

@karolpiotrowicz karolpiotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link
Copy Markdown
Collaborator

@karolpiotrowicz karolpiotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few issues to fix before merging — mostly in the new methods.md file.

Comment thread docs/deploy/agent-runtime/methods.md Outdated
Comment thread docs/deploy/agent-runtime/methods.md Outdated
Comment thread docs/deploy/agent-runtime/methods.md Outdated
Comment thread docs/deploy/agent-runtime/methods.md Outdated
Comment thread docs/deploy/agent-runtime/methods.md Outdated
Comment thread docs/deploy/agent-runtime/methods.md Outdated
@jcwriter74 jcwriter74 added the techwriting-review Issues reviewed by the GCP technical writing team label May 19, 2026
@kdroste-google kdroste-google force-pushed the goAgentEngine branch 2 times, most recently from 8afbd96 to 08d7701 Compare May 20, 2026 07:34
@kdroste-google
Copy link
Copy Markdown
Collaborator Author

I have removed "methods.md". Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

techwriting-review Issues reviewed by the GCP technical writing team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants