Google Firestore: implement agent demonstrating session persistence using Firestor for Java ADK#1563
Google Firestore: implement agent demonstrating session persistence using Firestor for Java ADK#1563mohan-ganesh wants to merge 1 commit intogoogle:mainfrom
Conversation
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2271995 to
af8f631
Compare
koverholt
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I see that this is based on a pending PR in adk-java (google/adk-java#1096), so we will need to wait for that PR to get reviewed and/or merged/released before we can review and suggest edits on this docs update. I'll mark this as blocked until that happens.
Once that happens, there are a number of issues that need to be addressed in this PR for consistency and formatting, but these can wait until the upstream PR in adk-java is reviewed:
- Use a icon/logo instead of a diagram for catalog icon
- Fix versions throughout and update version tag with corresponding Java version
FirestoreDatabaseRunnerrequiresgcs.adk.bucket.nameto be configured, which is not mentioned- Fill in the Configuration section with actual property names and examples
- Fix the
forecastkey ingetCurrentTime, should betimeor similar - Follow the established integration page structure per Contributing Guide
af8f631 to
b967be1
Compare
…sing Firestore database for java adk
b967be1 to
4cf1140
Compare
|
Thanks for the great feedback @koverholt ! I can certainly see the value in the information you added.
https://mvnrepository.com/artifact/com.google.adk/google-adk-firestore-session-service
Let me know if you need any further adjustments |
|
Thanks for the updates! Does this functionality depend on google/adk-java#1096 being merged and released? If so, let us know and we will re-review this docs PR when that is ready to test. |
|
thanks for the quick response @koverholt and this functionality is not dependent on https://github.com/google/adk-java/pull/1096 The changes https://github.com/google/adk-java/pull/1096 is about README.md on library component to reflect the latest versions on the example and documentation.. no functional changes |
| catalog_title: Session Management with Firestore | ||
| catalog_description: Session state management for ADK agents using Google Cloud Firestore | ||
| catalog_icon: /integrations/assets/firestore-session.jpg | ||
| catalog_tags: ["sessions", "database"] |
There was a problem hiding this comment.
Rather than introducing two new categories, let's use either the "data" tag or "google" tag (since it uses Firestore), or both.
| @@ -0,0 +1,202 @@ | |||
| --- | |||
| catalog_title: Session Management with Firestore | |||
There was a problem hiding this comment.
| catalog_title: Session Management with Firestore | |
| catalog_title: Firestore Session Service |
| @@ -0,0 +1,202 @@ | |||
| --- | |||
| catalog_title: Session Management with Firestore | |||
| catalog_description: Session state management for ADK agents using Google Cloud Firestore | |||
There was a problem hiding this comment.
| catalog_description: Session state management for ADK agents using Google Cloud Firestore | |
| catalog_description: Session state management for ADK agents using Firestore |
|
|
||
| !!! note | ||
|
|
||
| The `google-adk-firestore-session-service` version matches the core Google Agent ADK version. Ensure you use the same version for both libraries to guarantee compatibility. |
There was a problem hiding this comment.
| The `google-adk-firestore-session-service` version matches the core Google Agent ADK version. Ensure you use the same version for both libraries to guarantee compatibility. | |
| Ensure you use the same version for both `google-adk` and `google-adk-firestore-session-service` to guarantee compatibility. |
|
|
||
| ```properties | ||
| # Firestore collection name for storing session data | ||
| adk.firestore.collection.name=adk-session |
There was a problem hiding this comment.
These property names don't match the actual keys in FirestoreProperties.java. Can you confirm and fix if needed? And check this in google/adk-java#1096 as well.
adk.firestore.collection.namevs.firebase.root.collection.nameadk.gcs.bucket.namevs.gcs.adk.bucket.nameadk.stop.wordsvs.keyword.extraction.stopwords
This is an additional for "Integration"
This commit includes an example and details of Using the Google Cloud Firestore for Session management