Rename helpers to be more consistent with C++26#9731
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 19, 2026
Merged
Rename helpers to be more consistent with C++26#9731copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_885938517
branch
from
ab36072 to
7c6d23e
Compare
C++26 defines `add_sat`, `sub_sat`, and `saturate_cast`. I think we should use these names, with the expectation that we can remove our implementations at some point. This also motivates renaming some similar helpers not provided by C++26, e.g. `simd::convert` -> `simd::cast` PiperOrigin-RevId: 886215211
copybara-service
bot
force-pushed
the
test_885938517
branch
from
7c6d23e to
3681a46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename helpers to be more consistent with C++26
C++26 defines
add_sat,sub_sat, andsaturate_cast. I think we should use these names, with the expectation that we can remove our implementations at some point.This also motivates renaming some similar helpers not provided by C++26, e.g.
simd::convert->simd::cast