fix: increase initial 404 retries and add configurable retry option #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase default retry count from 5 to 10 for initial 404 errors - Add MAX_RETRY_DELAY_MS cap (30s) to prevent excessive wait times - Add optional initialRetries parameter to StreamActivitiesOptions This addresses issue google-labs-code#19 where streaming fails immediately after session creation because the activities endpoint isn't ready yet. With 10 retries and exponential backoff capped at 30s, the total wait time is approximately 5 minutes, which should be sufficient for most session initialization scenarios.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
@sanjay3290 Thank you so much. Can you sign the CLA? |
Author
|
@davideast i just did, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #19 where streaming fails immediately after session creation because the activities endpoint isn't ready yet.
Changes
initialRetriesparameter toStreamActivitiesOptionsfor user configurabilityBefore
After
initialRetriesoptionTesting
Tested with stress test framework that creates sessions and immediately streams:
Related Issues
Fixes #19