fix: remove stale deps, add lint script, pin CI bun version#98
Merged
Conversation
- Remove dead runtime dependencies with zero imports: ink, react, @json-render/core, @json-render/ink, mdast (type-only import, covered by @types/mdast) - Remove @types/react from devDependencies - Add package-level lint script (tsc --noEmit --skipLibCheck) so turbo lint actually runs - Fix 10 pre-existing type errors in handler.test.ts where properties.get() returns ResolvedValue but tests compared against raw primitives - Pin CI bun version to 1.3.9 to match root packageManager field instead of floating on latest - Use root-level turbo commands in CI instead of cd-ing into packages/cli - Add lint step to CI pipeline - Regenerate bun.lock after dependency removal bun install now completes with no peer warnings. bun run build, bun run test, and bun run lint all pass at the root. Closes #30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30
Issue #30 reported that the root build contract was broken and the CLI had stale dependencies. The
packageManagerfield and root turbo commands have since been fixed, but three things remained:ink,react,@json-render/core,@json-render/ink, andmdastwere still listed as runtime dependencies with zero imports in the source treeturbo lintran 0 tasks because there was no package-levellintscriptbun-version: latestandcd packages/cli && bun run buildinstead of the root build contractDependency cleanup
ink,react,@json-render/core,@json-render/ink,mdastfromdependencies@types/reactfromdevDependenciesbun installnow completes with no peer warningsLint script
"lint": "tsc --noEmit --skipLibCheck"topackages/cli/package.json--skipLibCheckmatches the build script and avoids pre-existingbun-typescompatibility noisehandler.test.tswhereproperties.get()returnsResolvedValue | undefinedbut tests compared against raw number/boolean primitivesCI updates
bun-version: 1.3.9to match rootpackageManagerfieldbun run build,bun run test) instead ofcd packages/cliworkaroundsLintstep that runs before tests