Skip to content

Comments

Update packages.#20152

Merged
jacob314 merged 1 commit intomainfrom
deprecated
Feb 24, 2026
Merged

Update packages.#20152
jacob314 merged 1 commit intomainfrom
deprecated

Conversation

@jacob314
Copy link
Contributor

@jacob314 jacob314 commented Feb 24, 2026

Summary

Fixes deprecated warnings with prebuild-install, node-domeexception and glob dependencies.

Fixes: #20199

@jacob314 jacob314 requested a review from a team as a code owner February 24, 2026 08:36
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 24, 2026

Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jacob314, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a comprehensive update and restructuring of the project's dependencies. The changes aim to streamline the dependency graph, potentially by simplifying the handling of optional or native modules through aliasing. It also involves a notable refresh of core build and utility packages, which could lead to improved performance, stability, or compatibility across different environments.

Highlights

  • Dependency Updates: The package.json and package-lock.json files have been updated to reflect numerous dependency changes, including additions, removals, and version bumps across various packages.
  • Optional Dependency Handling: The keytar and node-domexception packages have been replaced with npm:empty aliases in package.json, and their corresponding entries removed from package-lock.json. This suggests a strategy to manage optional dependencies or avoid native module compilation issues by providing a placeholder.
  • Build Toolchain Refinement: Several dependencies related to native module building and optional features (e.g., prebuild-install, detect-libc, tar-fs, buffer, ieee754) have been removed. Concurrently, new packages focused on JavaScript parsing, transformation, and utility functions (e.g., commoner, jstransform, recast, esprima-fb, ast-types, source-map, defined, detective, envify, through, amdefine, base62, private, q, webidl-conversions) have been introduced, indicating a significant update or refactoring of the project's build and utility infrastructure.
  • New Development Dependency: The domexception package has been added as a new development dependency.
Changelog
  • package-lock.json
    • Added 'domexception' as a new development dependency.
    • Removed 'keytar' from top-level dependencies.
    • Removed various optional/native-related dependencies including 'balanced-match', 'brace-expansion', 'glob' (nested), 'minimatch' (nested), 'bl', 'buffer', 'detect-libc', 'expand-template', 'fs-constants', 'github-from-package', 'ieee754', 'mkdirp-classic', 'napi-build-utils', 'node-abi', 'node-addon-api', 'node-domexception' (top-level), 'prebuild-install', 'simple-concat', 'simple-get', 'tar-fs', 'tar-stream', and 'tunnel-agent'.
    • Added new dependencies such as 'node_modules/@vscode/vsce/node_modules/keytar' (aliased to 'empty'), 'node_modules/amdefine', 'node_modules/ast-types', 'node_modules/base62', 'node_modules/commoner' (and its nested dependencies), 'node_modules/defined', 'node_modules/detective' (and its nested dependencies), 'node_modules/domexception' (top-level), 'node_modules/envify', 'node_modules/esprima-fb', 'node_modules/fetch-blob/node_modules/node-domexception' (aliased to 'empty'), 'node_modules/jstransform' (and its nested dependencies), 'node_modules/private', 'node_modules/q', 'node_modules/recast' (and its nested dependencies), 'node_modules/source-map' (top-level), 'node_modules/through', and 'node_modules/webidl-conversions'.
  • package.json
    • Added 'domexception' with version '^4.0.0' as a dev dependency.
    • Changed 'node-domexception' dependency to 'npm:empty@^0.10.1'.
    • Added 'keytar' dependency as 'npm:empty@^0.10.1'.
    • Removed 'keytar' from the 'optionalDependencies' section.
  • packages/core/package.json
    • Removed 'keytar' from the 'optionalDependencies' section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates package dependencies, most notably replacing the keytar native module with a stub to improve build stability. The changes in package.json and package-lock.json reflect this by removing keytar as an optional dependency and overriding it with the empty package. This is a sound strategy to avoid issues with native module compilation across different environments. The existing code that uses keytar appears to handle its absence gracefully. The other dependency updates seem to be routine maintenance. The changes look good.

@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Size Change: -2 B (0%)

Total Size: 25.7 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.3 MB -2 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the priority/p1 Important and should be addressed in the near term. label Feb 24, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 24, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Feb 24, 2026
@jacob314 jacob314 reopened this Feb 24, 2026
@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 24, 2026
@jacob314 jacob314 added this pull request to the merge queue Feb 24, 2026
@gemini-cli gemini-cli bot added area/core Issues related to User Interface, OS Support, Core Functionality and removed status/need-issue Pull requests that need to have an associated issue. labels Feb 24, 2026
Merged via the queue into main with commit 812794a Feb 24, 2026
53 checks passed
@jacob314 jacob314 deleted the deprecated branch February 24, 2026 18:18
@galz10
Copy link
Collaborator

galz10 commented Feb 24, 2026

/patch preview

@github-actions
Copy link

Patch workflow(s) dispatched successfully!

📋 Details:

  • Channels: preview
  • Commit: 812794a471ad2bc1a9c12da4c327ec7133a9d1df
  • Workflows Created: 1

🔗 Track Progress:

github-actions bot pushed a commit that referenced this pull request Feb 24, 2026
# Conflicts:
#	package.json
@github-actions
Copy link

🚀 Patch PR Created!

📋 Patch Details:

📝 Next Steps:

  1. ⚠️ Resolve conflicts in the hotfix PR first: #20204
  2. Test your changes after resolving conflicts
  3. Once merged, the patch release will automatically trigger
  4. You'll receive updates here when the release completes

🔗 Track Progress:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warnings when running Gemini CLI

3 participants