Revert "Fix: Persist manual model selection on restart #19864 (#19891)"

[Nixxx19]

This reverts commit ac04c38.

Related to #19864

[gemini-code-assist]

Summary of Changes

Hello @Nixxx19, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completely reverts a previous commit that attempted to fix the persistence of manual model selections, particularly for preview models, across application restarts. The revert removes the introduced logic and associated tests, simplifying the handling of preview model access by removing a null state and adjusting the conditions under which a user's model choice might be reset. This action suggests that the original fix may have introduced issues or was not the correct approach.

Highlights

• Reverted Model Persistence Logic: Undid changes related to persisting manual model selection, specifically for preview models, on application restart.
• Simplified Preview Model Access State: Changed the hasAccessToPreviewModel property from boolean | null to a simple boolean with a default of false, removing the 'unknown' (null) state.
• Updated Model Reset Condition: Modified the logic that determines when a user's selected model should be reset if they lose access to a preview model, aligning it with the simplified hasAccessToPreviewModel state.
• Removed Related Tests: Eliminated test cases specifically added to verify the model persistence fix, as the fix itself has been reverted.

Changelog

• packages/core/src/config/config.test.ts
  • Removed imports for specific content generator types and Gemini models.
  • Updated assertions for preview model access in test cases.
  • Deleted a dedicated test suite for model persistence.
• packages/core/src/config/config.ts
  • Changed hasAccessToPreviewModel property type and default value.
  • Modified the condition for resetting the user's model.
  • Updated the getter and setter for hasAccessToPreviewModel to reflect the simplified type.

Activity

• This pull request is a direct revert of a previous commit, indicating a decision to undo a prior change.
• No human activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts commit ac04c388e0862697a6bf9481a0219b70c4a075e3, which addressed persisting manual model selection on restart. The changes correctly undo the previous logic related to hasAccessToPreviewModel in Config and update the associated tests. The test suite for the reverted feature has also been removed. The revert appears clean and complete, with no apparent issues.