Skip to content

Comments

Add CodeQL analysis workflow configuration#18592

Closed
krsjenmt wants to merge 0 commit intogoogle-gemini:mainfrom
krsjenmt:main
Closed

Add CodeQL analysis workflow configuration#18592
krsjenmt wants to merge 0 commit intogoogle-gemini:mainfrom
krsjenmt:main

Conversation

@krsjenmt
Copy link

@krsjenmt krsjenmt commented Feb 9, 2026

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@krsjenmt krsjenmt requested a review from a team as a code owner February 9, 2026 03:32
@google-cla
Copy link

google-cla bot commented Feb 9, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Comment on lines 11 to 28
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [18.x, 20.x, 22.x]

steps:
- uses: actions/checkout@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: Build
run: |
npm install
npx webpack

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
@gemini-cli gemini-cli bot added the priority/p1 Important and should be addressed in the near term. label Feb 9, 2026
Copy link
Author

@krsjenmt krsjenmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upatde krsjenmt workflow

@krsjenmt krsjenmt requested a review from a team as a code owner February 9, 2026 07:54
Copy link
Author

@krsjenmt krsjenmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

Object.keys(groupedLogs).forEach((key) => {
if (next[key] === undefined) {
// Collapse play.googleapis.com by default
next[key] = !key.includes('play.googleapis.com');

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization

'[play.googleapis.com](1)' can be anywhere in the URL, and arbitrary hosts may come before or after it.
Comment on lines 1644 to 1649
const unescaped = full
.slice(1, -1)
.replace(/\\n/g, '\n')
.replace(/\\t/g, '\t')
.replace(/\\r/g, '\r')
.replace(/\\\\/g, '\\')

Check failure

Code scanning / CodeQL

Double escaping or unescaping

This replacement may produce '\' characters that are double-unescaped [here](1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant