feat: prompt users to run /terminal-setup with yes/no#16235
feat: prompt users to run /terminal-setup with yes/no#16235ishaanxgupta wants to merge 20 commits intogoogle-gemini:mainfrom
Conversation
Co-authored-by: Vedant Mahajan <Vedant.04.mahajan@gmail.com>
Summary of ChangesHello @ishaanxgupta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience for the interactive CLI by implementing a smart, one-time prompt. It guides users to configure essential multiline input keybindings via the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a helpful one-time prompt for users in certain terminals to configure multiline input, which improves the interactive CLI experience. The implementation correctly uses persistent state to ensure the prompt is only shown once and handles asynchronous operations safely within a useEffect hook. The logic for determining when to show the prompt is sound. My feedback focuses on improving code quality and maintainability by addressing code duplication and enhancing error handling in the newly added utility functions, aligning with established error handling guidelines. These changes will make the code easier to maintain and debug in the future.
|
@jacob314 @scidomino could you please review this and suggest any changes if needed |
|
@scidomino this PR is ready for review |
scidomino
left a comment
There was a problem hiding this comment.
When I tested this it wouldn't update my settings. it would immediately execute the
return () => {
cancelled = true;
};
so even if I select "yes" it doesn't make modifications because it thinks it's canceled.
Ah, I am really sorry this shouldn't happen. |
|
@ishaanxgupta ok. Let me know when you've fixed it and I'll review again. |
Remove comment about setting terminal setup prompt state.
|
@scidomino I checked the PR, the cancelled flag was being set immediately when the component re-rendered or unmounted, which happened before the async operations completed. This caused the flow to exit early even when you clicked "Yes". |
|
@ishaanxgupta I think you didn't push your changes to github. none of the commits in the last 5 days did anything other than add and remove comments. And when I run the code, it still fails as I described above. |
|
Closing because it's been 7 days with no response. Feel free to reopen when you're ready for review. |
|
hi @scidomino really sorry for that, could you please reopen this one? |
|
Reopened. Please fix and ping me when it's ready for review. |
Sure |
|
Note that others are interested in this issue so please let's get this in by monday. |
|
hi @scidomino WhatsApp.Video.2026-02-20.at.08.58.37.mp4 |
|
These lint errors are weird. I'm going to try rebasing this to see if it fixes things. |
|
Actually, the lint check is a legitimate failure: Please fix. |
|
In the future, please make sure |
@scidomino fixed the errors checked on local pls have a look |
|
Had you run |
Summary
This change introduces an opt‑in prompt in the interactive CLI that asks users, once, if they’d like to run the /terminal-setup command when it would actually help them (e.g., in VS Code / Cursor / Windsurf / Antigravity terminals that don’t yet have the multiline keybindings configured and don’t support Kitty/modifyOtherKeys).
Existing users who have already configured their terminal are not prompted.
The prompt -
Related Issues
Closes #16005
Pre-Merge Checklist
collaborated with @ved015