chore: Remove deprecated schedules/inject.py stub file#1548
Closed
harshaljanjani wants to merge 1 commit intogoogle-deepmind:mainfrom
Closed
chore: Remove deprecated schedules/inject.py stub file#1548harshaljanjani wants to merge 1 commit intogoogle-deepmind:mainfrom
harshaljanjani wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Author
Collaborator
|
We’re in the process of resolving some internal conflicts #1414 (comment) so we might need to hold off on merging this for a sec, sorry! |
Author
|
No worries, thanks for the update @rdyro! |
vroulet
approved these changes
Jan 22, 2026
Collaborator
vroulet
left a comment
vroulet
left a comment
There was a problem hiding this comment.
Should be good, thanks!
Author
Author
Collaborator
|
Hey, thanks for this PR! For this, we unfortunately had to remove this internally-first because of unrelated issues, thanks for the reminder on this though! The file should be gone now, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First contribution!
→ This PR removes the deprecated import stub file
optax/schedules/inject.py, as indicated by the TODO comment. The file was a simple import stub that re-exportedInjectHyperparamsStateandinject_hyperparamsfromoptax/schedules/_inject.py; all imports in the codebase already use the actual implementation in_inject.py.