Streamline interface of tree_norm function.#1369
Closed
carlosgmartin wants to merge 1 commit intogoogle-deepmind:mainfrom
Closed
Streamline interface of tree_norm function.#1369carlosgmartin wants to merge 1 commit intogoogle-deepmind:mainfrom
carlosgmartin wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Collaborator
|
The user will expect the same behavior as in jax, so we will stay as close as possible to jax.numpy.linalg.norm. |
Contributor
Author
|
@vroulet $ py -c "from jax import numpy as jnp; jnp.linalg.norm(jnp.zeros(3), ord='inf')"
ValueError: Invalid order 'inf' for vector norm.Use 'jax.numpy.inf' instead.$ py -c "from jax import numpy as jnp; jnp.linalg.norm(jnp.zeros(3), ord='infinity')"
ValueError: Invalid order 'infinity' for vector norm.I'd also argue that the narrower type of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines and simplifies the interface for
optax.tree.norm(no need for 3 different ways to specify the infinity norm, and 2 different ways to specify the 2-norm).Split into a new PR from #1365.