Skip to content

Fix infinite recursion in LoRA module repr when inside interceptor #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arJ-V wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix infinite recursion in LoRA module repr when inside interceptor #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions gemma/peft/_lora.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,16 @@ def __post_init__(self):
if self.scope is not None:
nn.share_scope(self, self.wrapped)

def __repr__(self) -> str:
"""Custom repr to avoid infinite recursion when inside interceptor."""
wrapped_type = type(self.wrapped).__name__
return (
f'{type(self).__name__}(rank={self.rank}, '
f'wrapped={wrapped_type}(features={self.wrapped.features}))'
)

@nn.compact
def __call__(self, inputs: Array) -> Array:
# TODO(epot): Fix infinite recursion when `repr(self.wrapped)` inside
# interceptor.
adapter = LoRADenseAdapter(
name='lora',
rank=self.rank,
Expand Down Expand Up @@ -154,6 +160,15 @@ def __post_init__(self):
if self.scope is not None:
nn.share_scope(self, self.wrapped)

def __repr__(self) -> str:
"""Custom repr to avoid infinite recursion when inside interceptor."""
wrapped_type = type(self.wrapped).__name__
return (
f'{type(self).__name__}(rank={self.rank}, '
f'wrapped={wrapped_type}(einsum_str={self.wrapped.einsum_str}, '
f'shape={self.wrapped.shape}))'
)

@nn.compact
def __call__(self, inputs: Array, einsum_str: str | None = None) -> Array:
# Warning: Calling multiple times with different `einsum_str` will
Expand Down Expand Up @@ -265,6 +280,15 @@ def __post_init__(self):
if self.scope is not None:
nn.share_scope(self, self.wrapped)

def __repr__(self) -> str:
"""Custom repr to avoid infinite recursion when inside interceptor."""
wrapped_type = type(self.wrapped).__name__
return (
f'{type(self).__name__}(rank={self.rank}, '
f'wrapped={wrapped_type}(features={self.wrapped.features}, '
f'axis={self.wrapped.axis}, batch_dims={self.wrapped.batch_dims}))'
)

@nn.compact
def __call__(self, inputs: Array) -> Array:
adapter = LoRADenseGeneralAdapter(
Expand Down