feat: add support for MatchAttributeFilters#1477
Open
no23reason wants to merge 4 commits intogooddata:masterfrom
Open
feat: add support for MatchAttributeFilters#1477no23reason wants to merge 4 commits intogooddata:masterfrom
no23reason wants to merge 4 commits intogooddata:masterfrom
Conversation
This is to bring in the new attribute filter types. JIRA: CQ-2005 risk: low
This reflects the filter type recently added on the backend. Support it also in the compute_to_sdk_converter JIRA: CQ-2005 risk: low
This reflects the filter type recently added on the backend. Support it also in the visualization_to_sdk_converter. JIRA: CQ-2005 risk: low
This reflects the filter type recently added on the backend. JIRA: CQ-2005 risk: low
3e3295f to
cabf28e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1477 +/- ##
==========================================
+ Coverage 77.27% 77.31% +0.03%
==========================================
Files 227 227
Lines 14687 14761 +74
==========================================
+ Hits 11350 11413 +63
- Misses 3337 3348 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reflects the new Attribute filter type recently added to the backend:
Also, the client was re-generated to bring in the relevant server-side types.
JIRA: CQ-2005
risk: low