Skip to content

feat: add support for MatchAttributeFilters#1477

Open
no23reason wants to merge 4 commits intogooddata:masterfrom
no23reason:dho/cq-2005-filters
Open

feat: add support for MatchAttributeFilters#1477
no23reason wants to merge 4 commits intogooddata:masterfrom
no23reason:dho/cq-2005-filters

Conversation

@no23reason
Copy link
Contributor

This reflects the new Attribute filter type recently added to the backend:

  • handles compute model
  • handles visualization model
  • handles FlexConnect

Also, the client was re-generated to bring in the relevant server-side types.

JIRA: CQ-2005
risk: low

This is to bring in the new attribute filter types.

JIRA: CQ-2005
risk: low
This reflects the filter type recently added on the backend.
Support it also in the compute_to_sdk_converter

JIRA: CQ-2005
risk: low
This reflects the filter type recently added on the backend.
Support it also in the visualization_to_sdk_converter.

JIRA: CQ-2005
risk: low
This reflects the filter type recently added on the backend.

JIRA: CQ-2005
risk: low
@no23reason no23reason force-pushed the dho/cq-2005-filters branch from 3e3295f to cabf28e Compare March 19, 2026 10:12
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 85.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.31%. Comparing base (b65ee3f) to head (cabf28e).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...ddata-sdk/src/gooddata_sdk/compute/model/filter.py 90.90% 5 Missing ⚠️
...data_sdk/compute/visualization_to_sdk_converter.py 0.00% 4 Missing ⚠️
...gooddata_flexconnect/function/execution_context.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
+ Coverage   77.27%   77.31%   +0.03%     
==========================================
  Files         227      227              
  Lines       14687    14761      +74     
==========================================
+ Hits        11350    11413      +63     
- Misses       3337     3348      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@no23reason no23reason enabled auto-merge March 19, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant