x/pkgsite: Adding function to setup server#3
x/pkgsite: Adding function to setup server#3laches1sm wants to merge 3 commits intogolang:masterfrom
Conversation
…to problematic areas of the tests
|
This PR (HEAD: 904b871) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/pkgsite/+/241458 to see it. Tip: You can toggle comments from me using the |
|
Message from Jonathan Amsterdam: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241458. |
|
Message from Rebecca Martin: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241458. |
|
Message from Julie Qiu: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241458. |
|
Message from Rebecca Martin: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241458. |
|
Message from Julie Qiu: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241458. |
|
Message from Rebecca Martin: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/241458. |
|
Message from Jonathan Amsterdam: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241458. |
|
Message from Rebecca Martin: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241458. |
|
Message from Jonathan Amsterdam: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241458. |
What changes does this PR bring?
This PR implements a new function,
CreateAndInstallServer(), which refactors duplicated parts of code surrounding the creation and installation of routes and places it into this function.For now, I've placed this function within the server.go - please tell me if there's a better place for it!
Thank you all very much in advance for your feedback :D