fix(views): enable searching and fix selection flow in TUI lists#773
Open
Sypher845 wants to merge 2 commits intogoharbor:mainfrom
Open
fix(views): enable searching and fix selection flow in TUI lists#773Sypher845 wants to merge 2 commits intogoharbor:mainfrom
Sypher845 wants to merge 2 commits intogoharbor:mainfrom
Conversation
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
=========================================
- Coverage 10.99% 7.79% -3.20%
=========================================
Files 173 270 +97
Lines 8671 13170 +4499
=========================================
+ Hits 953 1027 +74
- Misses 7612 12030 +4418
- Partials 106 113 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the TUI selection list behavior so users can filter items by name and don’t accidentally exit the program while applying a filter (addressing #772).
Changes:
- Enabled Bubble List filtering by returning the item’s string value from
FilterValue(). - Adjusted Enter-key handling so Enter applies the filter first (when filtering), and only selects/quits when not in filtering mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
Contributor
Author
|
the test is failing as demo.goharbor is down |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the interactive selection lists where the search filter was not working and the program would close too early when trying to filter.
Type of Change
Please select the relevant type.
Changes