Docker: Use of alpine, pass in env vars and use pm2-runtime#3
Open
jleeh wants to merge 4 commits intogoerli:masterfrom
Open
Docker: Use of alpine, pass in env vars and use pm2-runtime#3jleeh wants to merge 4 commits intogoerli:masterfrom
jleeh wants to merge 4 commits intogoerli:masterfrom
Conversation
j16r
approved these changes
Apr 12, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
app.jsonfile. This is due to them having precedent over passed in environment variables and defaults are already set inlib/node.jsemitinstance function for sending the hello/login message so errors are shown on failure and the message can be traced in the logsDocker refactor wins:
pm2-runtimewith no daemon mode allows the entrypoint to be a pm2 command which stops the container if the client quits, rather than forever running just withtail -feven if the client exits.Please also rectify #2 so we can get the correct automated Docker hub builds.