Skip to content

Updated Qt backend#2

Open
kriben wants to merge 14 commits intogoeran:masterfrom
kriben:master
Open

Updated Qt backend#2
kriben wants to merge 14 commits intogoeran:masterfrom
kriben:master

Conversation

@kriben
Copy link

@kriben kriben commented Aug 9, 2011

I have updated the Qt backend to handle the playground.js example.

Highlights:

  • Started using the AST for creating the widgets.
  • Button, textbox and label implemented.
  • Button clicks and setting text in text boxes works.
  • Implemented absolute positioning of widgets.

@goeran
Copy link
Owner

goeran commented Aug 11, 2011

Let's merge in your changes on friday. Because I'm going to refactored the design - just as we talked about during lunch @ work.

Another tips when you create a pull request is to squash your commits into fewer. You could have squashed all your commits into a commit with this comment; "Implemented a simple Qt runtime, it's now possible to run workstation on a linux box." - or something like that:)

@goeran
Copy link
Owner

goeran commented Aug 12, 2011

Never mind the squashing, but it would be nice if you could pull the latest changes, and then create a new pull request.

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants