-
-
Notifications
You must be signed in to change notification settings - Fork 36
chore: enable tests in pipeline #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # .github/workflows/build_android.yml # .github/workflows/build_ios.yml # .github/workflows/build_linux.yml # .github/workflows/build_macos.yml # .github/workflows/build_web.yml # .github/workflows/build_windows.yml # .github/workflows/runner.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! However, unless there's a specific reason not to, I think we should stick to PNPM lockfiles for consistency.
Only other thing — which I can do as a follow-up — whilst I check-in types into my own codebase, I think for tests we probably want to generate them. In order to ensure we've not broken codegen. But I don't think that's even possible atm — only exposed via the UI. So I'll need to look into exposing that via CLI.
Would be nice to generate all the files via CLI <3 |
closes #94