Skip to content

Conversation

@nmerget
Copy link
Contributor

@nmerget nmerget commented Jun 2, 2025

closes #94

Copy link
Member

@Benjamin-Dobell Benjamin-Dobell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! However, unless there's a specific reason not to, I think we should stick to PNPM lockfiles for consistency.

Only other thing — which I can do as a follow-up — whilst I check-in types into my own codebase, I think for tests we probably want to generate them. In order to ensure we've not broken codegen. But I don't think that's even possible atm — only exposed via the UI. So I'll need to look into exposing that via CLI.

@nmerget
Copy link
Contributor Author

nmerget commented Dec 11, 2025

Looks great! However, unless there's a specific reason not to, I think we should stick to PNPM lockfiles for consistency.

Only other thing — which I can do as a follow-up — whilst I check-in types into my own codebase, I think for tests we probably want to generate them. In order to ensure we've not broken codegen. But I don't think that's even possible atm — only exposed via the UI. So I'll need to look into exposing that via CLI.

Would be nice to generate all the files via CLI <3

@nmerget nmerget enabled auto-merge (squash) December 11, 2025 11:49
@nmerget nmerget dismissed Benjamin-Dobell’s stale review December 11, 2025 12:19

Removed package-lock.json

@nmerget nmerget merged commit cafca17 into main Dec 11, 2025
38 checks passed
@nmerget nmerget deleted the chore-enable-tests-in-pipeline branch December 11, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test step for editor builds (linux,macos,windows) in CICD

3 participants