Support Commit Amends

[sorascode]

This PR adds support for Commit Amends for Editor VCS.

Related Git Plugin PR: godotengine/godot-git-plugin#323

[YeldhamDev]

You need to handle the compatibility break: https://docs.godotengine.org/en/latest/engine_details/development/handling_compatibility_breakages.html

[sorascode]

You need to handle the compatibility break: https://docs.godotengine.org/en/latest/engine_details/development/handling_compatibility_breakages.html

done:)

[YeldhamDev]

I get this error when trying to amend:

  ERROR: editor/version_control/editor_vcs_interface.h:112 - Required virtual method GitPlugin::_commit must be overridden before calling.

Also, the amending itself doesn't work. I get that it's because it needs to also be implemented in the plugin itself, but that means that the "Amend" toggle is useless for plugins that don't.

Ideally, it should find a way to check if the plugin is capable of this, and only then show the toggle.

[sorascode]

@YeldhamDev

The error should no longer appear, now there should only be an error if neither the new _commit method nor the now deprecated _commit is overridden. I've also added a new method called _allow_amends, which can be overridden and can return either true or false depending on if the plugin supports amends. If it is not overridden we assume that it does not support amends.

I also have a local version of the Godot Git Plugin which supports amends. I can share the plugin (I can only build for macOS though) or a patch file of the changes.

[YeldhamDev]

You should open a PR with those changes there, so one can test it with this PR.

[sorascode]

Ok @YeldhamDev. I've made a PR for the Git Plugin: godotengine/godot-git-plugin#323. It uses this version of the cpp bindings: godotengine/godot-cpp#1963. Lmk if you have any issues.

[sorascode]

I've been informed that one off extension changes should not be done. I've closed the PR. The updated cpp bindings can still be found here https://github.com/sorascode/godot-cpp-soras-version/tree/commit-amends. Or if one only want to override the extension_api.json it can be found here https://github.com/sorascode/godot-cpp-soras-version/blob/commit-amends/gdextension/extension_api.json.

[YeldhamDev]

Tested on my end, feature works correctly.

[Repiteo]

Thanks!