Use font-lock-preprocessor-face for annotations#209
Open
charjr wants to merge 3 commits into
Open
Conversation
charjr
force-pushed
the
extract-annotations
branch
from
a34ebfc to
127aff4
Compare
Having the @ symbol made completion add a second @ symbol when completing. Though ideally completion should be filtered based on whether an @ symbol is present or not, that is out of scope for this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Separates Annotations from keywords so they can use a different face.
I picked the
font-lock-preprocessor-facesince GDScript TS Mode uses this already:emacs-gdscript-mode/gdscript-ts-mode.el
Lines 161 to 164 in dde79a1
Side Note
The highlighting could be simplified to just take any string after an@symbol, this would be more performant and less maintenance. But since the keywords exist and provide some additional completion, I just used them for now.Simplified the regex to match Godot editor behaviour: Godot immediately highlights anything starting with @.