Skip to content

Don't write buffers section if buffer is empty#59

Open
danwillm wants to merge 2 commits intogodotengine:masterfrom
danwillm:empty-buffer
Open

Don't write buffers section if buffer is empty#59
danwillm wants to merge 2 commits intogodotengine:masterfrom
danwillm:empty-buffer

Conversation

@danwillm
Copy link
Copy Markdown

@danwillm danwillm commented Jul 1, 2024

I have an fbx file that when procced through FBX2gLTF produced the buffers json segment as:

"buffers": [
{
"byteLength": 0
}
],

Which is not valid in gltf. Instead, omit this from being written to the file by only writing non-empty json.

Comment thread src/gltf/properties/BufferData.cpp Outdated
@danwillm
Copy link
Copy Markdown
Author

Hey, anything else you'd like me to resolve for this to be merged?

@fire
Copy link
Copy Markdown
Member

fire commented Jul 31, 2024

I haven't had much testing of this since in Godot 4.3 we switched to ufbx. I'll merge and it'll generate builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants