This repository was archived by the owner on Dec 31, 2025. It is now read-only.
Suppress unused method warning when using custom-godot feature#1084
Closed
mivort wants to merge 1 commit intogodot-rust:masterfrom
Closed
Suppress unused method warning when using custom-godot feature#1084mivort wants to merge 1 commit intogodot-rust:masterfrom
mivort wants to merge 1 commit intogodot-rust:masterfrom
Conversation
When `custom-godot` feature is used during build, the following warning
gets produced:
```
warning: function `godot_version` is never used
|
50 | fn godot_version() -> Option<semver::Version> {
| ^^^^^^^^^^^^^
|
```
This PR adds `#[allow(unused)]` directive to suppress this warning,
since it becomes unused when `custom-godot` feature is enabled.
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdnative/pr-1084 |
Member
|
Thanks for the contribution! Please note about this; CI would need some work before we can merge again. |
Bromeon
added
the
quality-of-life
Bromeon
added
the
status: buried
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
custom-godotfeature is used during build, the following warning gets produced:This PR adds
#[allow(unused)]directive to suppress this warning, since it becomes unused whencustom-godotfeature is enabled.