Fix form inputs missing min-height and padding#2649
Open
jnealey-godaddy wants to merge 2 commits intogodaddy-wordpress:masterfrom
Open
Fix form inputs missing min-height and padding#2649jnealey-godaddy wants to merge 2 commits intogodaddy-wordpress:masterfrom
jnealey-godaddy wants to merge 2 commits intogodaddy-wordpress:masterfrom
Conversation
Adds fallback CSS rules for form inputs to ensure consistent display across themes. Includes minimum height of 40px for accessibility and consistent padding. Fixes godaddy-wordpress#2648
Changes px values to rem for better scalability across themes: - min-height: 40px → 2.5rem - padding: 8px 12px → 0.5rem 0.75rem This allows the sizing to scale proportionally with the theme's base font size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2648
This PR adds fallback CSS rules for form inputs to ensure consistent display across themes that don't provide their own form styling.
Changes
min-height: 2.5remto text, email, tel, url, date, number inputs and select elementspadding: 0.5rem 0.75remto all form inputs including textareasTesting