fix(recover): re-enqueue orphan StateReady tasks#4
Merged
Conversation
When a process crashes between BLPOP and the state update inside PopTask, the task ID is removed from the ready list but the task in Redis is still in StateReady. recover() previously skipped such tasks on the assumption that StateReady implied ready-list membership, leaving the task as an orphan until its TTL expired. This change has recover() pre-fetch each topic's ready list once and RPUSH any StateReady task whose ID is missing. Tests cover both the orphan and live-task cases — the live-task test guards against duplicate enqueues on restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
What
When a process crashes between BLPOP and the state update inside
PopTask, the task ID is removed from the ready list but the task in Redis is still inStateReady. On restart,recover()sawStateReadyand skipped the task — assuming the ID was still on the ready list — so the task sat as an orphan until its TTL expired.This change has
recover()pre-fetch each topic's ready list once andRPUSHanyStateReadytask whose ID is missing.Why this approach
ReadyListIDs,RequeueReady) and a few lines inrecover().LRANGEper topic on startup; orphan check is O(1) per task after that.LRANGEfails we fall back to "treat the set as empty" — orphans get re-enqueued (correct), live IDs get duplicated (harmless: the duplicate becomes a stale ID once the original is popped).A fully crash-safe pop (BLMOVE + processing list + reaper, or Redis Streams with consumer groups) is a larger redesign and intentionally out of scope here.
Test plan
TestQueue_Recover_OrphanReadyTask— plants aStateReadytask with no ready-list entry, asserts it gets popped afterStartTestQueue_Recover_LiveReadyTaskNotDuplicated— plants aStateReadytask that is on the ready list, asserts the list size stays at 1 afterStartgo test -count=1 ./...)The pre-existing flake in
TestStress_TimeWheel_Concurrent_4Writersunder-raceis reproducible on master and unrelated — happy to look at it separately.