Add link recovery on EOF for TCP header#24
Closed
gq0 wants to merge 5 commits intogoburrow:masterfrom
grid-x:master
Closed
Add link recovery on EOF for TCP header#24gq0 wants to merge 5 commits intogoburrow:masterfrom grid-x:master
gq0 wants to merge 5 commits intogoburrow:masterfrom
grid-x:master
Conversation
…o the first ACK request, but connecting request come through
…he retry reason, further add some logging
nqv
reviewed
Sep 29, 2017
| } | ||
| } | ||
|
|
||
| func (mb *tcpTransporter) processResponse(aduRequest []byte) (aduResponse []byte, err error) { |
Member
There was a problem hiding this comment.
Would you please keep the variable name data instead of aduRequest? I think io.ReadFull(mb.conn, aduRequest[:]) is a bit confusing.
Author
There was a problem hiding this comment.
Good point, I add the feedback in latest commit + it should be buildable with older versions of go now as well. Thanks for the input.
…sData and replace time.Until to make it buildable with older go versions
Author
|
Changed the branch, please see #25 |
kgritesh
pushed a commit
to pashi-corp/modbus
that referenced
this pull request
Apr 30, 2021
fix(test): ascii & rtu over tcp client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solar Edge PV inverters almost always won't respond to the first ACK request, but consecutive requests come through. Therefore, on demand, it 'd be good to retry to establish a new connection and try it again. The headline of this repository say fault-tolerant; therefore, I think this feature comes in handy 😸