feat!: add container resource limits and build isolation tracking#654
feat!: add container resource limits and build isolation tracking#654
Conversation
Signed-off-by: Dax Johnson <delta592@gmail.com>
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (70.13%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
===========================================
+ Coverage 58.24% 70.13% +11.88%
===========================================
Files 123 123
Lines 8368 8517 +149
===========================================
+ Hits 4874 5973 +1099
+ Misses 3283 2301 -982
- Partials 211 243 +32
🚀 New features to boost your workflow:
|
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
…d, yet is essential. Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
|
Apologies for the misunderstanding. I did say I wasn't going to look at these changes at almost 1am on Saturday 😅 but I never indicated why. The reviewdog/codecov checks are not required checks in our setup (although Are there outstanding So, sorry you went through that. Addressing all outstanding For fun, I tried applying our We're wrapping up the current release (and might be distracted with other priorities), so it might be a few before we get to review the core changes within this PR, but thanks for taking a stab at it! 🙇🏼 |
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
Signed-off-by: Dax Johnson <delta592@gmail.com>
|
Thanks for the context and guidance! Now I understand more what needs to be fixed for only related items in CI. I did open a separate PR #655 for just the code changes and those respective golangci-lint and tests. I can close this PR in favor of the other. |
This PR shouldn't be this crazy, but @wass3r absolutely required I fix many years of reviewdog failures before @wass3r would even considering a review and merge. @plyr4 @ecrupper i don't mind, but it ballooned my original changes, so this review might take a while to review.
My actual changes are in commit 58cc3f0
here's hoping @wass3r doesn't need codecov to review. if so, i can attempt to fix those as well.