-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Feat: uds_exists validator #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: uds_exists validator #1482
Conversation
89dc794 to
94e0bfc
Compare
94e0bfc to
4b86d5b
Compare
zemzale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like the tests to be cleaner, but otherwise looks good
fbd77fd to
6d339b6
Compare
deankarn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one question
.golangci.yaml
Outdated
| - varnamelen | ||
| - wrapcheck | ||
| - wsl | ||
| - modernize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why this is required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see #1487 already excluded this linter. Therefore actually not really required anymore. I will do the adjustment.
7cb79fc to
659afce
Compare
|
I think I should've avoided rebasing.. |
Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers
As discussed in: #1348