Skip to content

Conversation

@barash-asenov
Copy link
Contributor

@barash-asenov barash-asenov commented Oct 30, 2025

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

As discussed in: #1348

@barash-asenov barash-asenov requested a review from a team as a code owner October 30, 2025 17:44
@coveralls
Copy link

coveralls commented Oct 30, 2025

Coverage Status

coverage: 73.814% (+0.03%) from 73.789%
when pulling 659afce on barash-asenov:bux-unix-addr-is-useless
into e9b900c on go-playground:master.

@barash-asenov barash-asenov reopened this Oct 30, 2025
@barash-asenov barash-asenov marked this pull request as draft October 31, 2025 07:39
@barash-asenov barash-asenov changed the title [fix] fix unix addr resolution Fix: unix socket resolution Oct 31, 2025
@barash-asenov barash-asenov force-pushed the bux-unix-addr-is-useless branch 2 times, most recently from 89dc794 to 94e0bfc Compare October 31, 2025 12:19
@barash-asenov barash-asenov changed the title Fix: unix socket resolution Feat: uds_exists validator Oct 31, 2025
@barash-asenov barash-asenov marked this pull request as ready for review October 31, 2025 12:21
@barash-asenov barash-asenov force-pushed the bux-unix-addr-is-useless branch from 94e0bfc to 4b86d5b Compare October 31, 2025 12:31
zemzale
zemzale previously approved these changes Dec 4, 2025
Copy link
Member

@zemzale zemzale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like the tests to be cleaner, but otherwise looks good

zemzale
zemzale previously approved these changes Dec 19, 2025
deankarn
deankarn previously approved these changes Dec 21, 2025
Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one question

.golangci.yaml Outdated
- varnamelen
- wrapcheck
- wsl
- modernize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why this is required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see #1487 already excluded this linter. Therefore actually not really required anymore. I will do the adjustment.

@barash-asenov barash-asenov dismissed stale reviews from deankarn and zemzale via 7cb79fc December 22, 2025 11:48
@barash-asenov
Copy link
Contributor Author

I think I should've avoided rebasing..

@zemzale zemzale merged commit 65b1bcc into go-playground:master Dec 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants