Open
Conversation
dmitshur
reviewed
Mar 31, 2026
Member
dmitshur
left a comment
dmitshur
left a comment
There was a problem hiding this comment.
The change to document Fedora/RHEL-based system requirements seems reasonable. See an inline comment about the other change.
| if err := glfw.Init(); err != nil { | ||
| log.Fatalln("failed to initialize glfw:", err) | ||
| } | ||
| defer glfw.Terminate() |
Member
There was a problem hiding this comment.
Let's not include this. It wouldn't compile anyway because it doesn't have a "glfw" import, and the window opening code is still "...". This example isn't meant to be complete code; we have https://github.com/go-gl/example for that. In theory this package can be used with something other than glfw, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added additional information regarding setup on Fedora/RHEL systems.
I have also added glfw initialization to the code example.