Fixed typos

[muesli]

Simple, nit-picky typo fixes.

[sapk]

Thx for your contrib and your catch.
The function name is also malformated (golang comments need to start with function name). The function should be renamed and any reference to it also.

[muesli]

Wow, hah, didn't notice that! Will fix.

[muesli]

Ok, I see: this stems from a typo in go-macaron. Will try to fix this upstream first. Could be interesting as it's a breaking API change.

[muesli]

For reference: go-macaron/session#29

[lafriks]

Methods must be renamed also

[muesli]

@lafriks Yeah, see comments above in this PR. It's a bit of an upstream-induced mess.

[zeripath]

Sorry this won't work. They're part of an external API

[zeripath]

Thanks for your attempt but this just won't work unless we either:

• Get upstream fixed (unlikely as there's been a pr proposing this fix for years)
• Fork upstream, bring in-house and fix ourselves - in which case we can remove these files and fix the session provider directly
• Migrate to some other session provider

[6543]

fix this on our side: https://gitea.com/macaron/session/ ?

[zeripath]

@6543 I think the macaron.Session.Destory ones have been fixed and are in the gitea git. Not sure if the session shim was updated at the same time though. I'll remove my review if you want to bring this PR back to life.

[6543]

If so not now

[lunny]

Yes, this could be closed I think.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@41c7aa5). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7552   +/-   ##
=========================================
  Coverage          ?   41.67%           
=========================================
  Files             ?      529           
  Lines             ?    68542           
  Branches          ?        0           
=========================================
  Hits              ?    28565           
  Misses            ?    36324           
  Partials          ?     3653

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c7aa5...1f7a313. Read the comment docs.

[sapk]

Updating the PR with last changes master seems to pass and the change is void now.

This was implemented by https://gitea.com/macaron/session/pulls/7 and #7933

I will close this PR because it has been implemented elsewhere and not needed anymore. Thanks @muesli for the finding and PR.