Misc icon tweaks, relax lint rules

[silverwind]

1. Use octicon-repo-locked to indicate private repos, also visible on the repo header now
2. Use octicon-repo-forked to indicate forked repos
3. Fix pull icons on pulse page
4. Remove "gold" color from private icons, we have been removing this color on frontpage repolist, so now the rest of the UI is also consistent. Also remove the now-unused gold color.

[silverwind]

Regarding octicon-repo-locked: I'm not sure it's actually right. I checked GH and they do not use it for the purpose of private repos at all. All they do is show a octicon-lock besides repo names in some places. So I think I will revert this change.

[silverwind]

Regarding octicon-repo-locked: I'm not sure it's actually right. I checked GH and they do not use it for the purpose of private repos at all. All they do is show a octicon-lock besides repo names in some places. So I think I will revert this change.

Maybe this icon is actually fine. I think a repo book icon with a padlock is better than a padlock only. We do not have a "locked" state yet for repos, so this icon is unambiguous too.

[silverwind]

One more minor change, ShowRepoAvatar is now enabled in repo lists, meaning they will render the repo avatar. This affects at least the explore repo list and org repo list.

[lunny]

A repository can fall into several state groups:

• Group 1: IsMirror, IsFork, IsRegular
• Group 2: IsTemplate
• Group 3: Public, Private

We can add icons for the states in Group 1, and use text labels for the other groups to maintain consistency and avoid visual conflicts.

[silverwind]

Sounds like a plan, I will try that.

[silverwind]

Applied that logic, so there is only 3 states of the repo icon now.

Also, I disabled lint rules that forbid "else-return" constructs. I find those just annoying because they forbid code like this and fixing it breaks the symmetry of the block which looks ugly.

  } else {
    return 'octicon-repo';
  }

[silverwind]

Ready now, I think it's a good cleanup and now all repo icons are the same everywhere.

[lunny]

It's better to have labels(private, template & etc.) for this repository

[silverwind]

You mean adding labels in this specific place (and below)?

[lunny]

I mean, it appears that the labels are only shown on the repository detail page. They could also be displayed on the list page, but I’m not sure whether we should enable that.

[silverwind]

In lists we can add them, yes.

[lunny]

Same as the above

[wxiaoguang]

IsTemplate is missing in icon.tmpl

If intentionally, should the comment #36046 (comment) be added to the template code? ps: I don't understand why IsTemplate is in a separate "group".

[lunny]

Both mirror repositories and regular repositories(public or private) could be template repositories.

[wxiaoguang]

If intentionally, should the comment #36046 (comment) be added to the template code? ps: I don't understand why IsTemplate is in a separate "group".

If intentionally, should the comment #36046 (comment) be added to the template code?

[silverwind]

I can add it. And yes I've implemented that only group 1 is represented with the icon, all other groups are represented with tags in places that have enough room to display them (not on frontpage repo list).

[silverwind]

Thought maybe we should make an exception for templates. I think it's highly unlikely that a repo is both a mirror and a template, so I guess showing a template icon in such a case would make more sense.