Fix double-subtraction of strut in _NET_WORKAREA height#70
Merged
fredkiefer merged 1 commit intognustep:masterfrom Jan 31, 2026
Merged
Fix double-subtraction of strut in _NET_WORKAREA height#70fredkiefer merged 1 commit intognustep:masterfrom
fredkiefer merged 1 commit intognustep:masterfrom
Conversation
Per the EWMH spec, _NET_WORKAREA returns a geometry that already excludes space reserved by _NET_WM_STRUT. Subtracting origin.y from the height double-counted the top strut, making the reported workarea shorter than it should be. For example, a 22px top strut on a 1080px screen yields _NET_WORKAREA height=1058. The code subtracted 22 again, producing height=1036 — a 22px shortfall causing mispositioned windows. Remove the incorrect height adjustment; keep the origin.y zeroing for GNUstep's bottom-left coordinate system. Bug uncovered while developing Gershwin Desktop (https://github.com/gershwin-desktop).
fredkiefer
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the EWMH spec,
_NET_WORKAREAreturns a geometry that already excludes space reserved by_NET_WM_STRUT. Subtractingorigin.yfrom the height double-counted the top strut, making the reported workarea shorter than it should be.For example, a 22px top strut on a 1080px screen yields
_NET_WORKAREAheight=1058. The code subtracted 22 again, producing height=1036 — a 22px shortfall causing mispositioned windows.Remove the incorrect height adjustment; keep the
origin.yzeroing for GNUstep's bottom-left coordinate system.Bug uncovered while developing Gershwin Desktop.