Open
Conversation
- Convert Register, Upvote, Downvote, and AddComment URLs to txlink.Call() - Use builder pattern for AddComment to allow user-editable text field - Cache match count to reduce redundant len() calls
Intermarch3
reviewed
Nov 26, 2025
Comment on lines
+40
to
+42
| - `send`: The bounty amount in ugnot (1 GNOT = 1,000,000 ugnot) | ||
|
|
||
| **Minimum bounty**: 1 GNOT (1,000,000 ugnot) |
There was a problem hiding this comment.
gnot will be non-transferrable upon launch so you will not be able to use it to pay for things (usable only for gas)
Contributor
Author
There was a problem hiding this comment.
on staging we can transfer gnot
Comment on lines
+68
to
+84
| // Create the application | ||
| application := &Application{ | ||
| ID: applicationCount, | ||
| BountyID: bountyID, | ||
| Applicant: caller, | ||
| PRLink: prLink, | ||
| AppliedAt: time.Now(), | ||
| Status: StatusPending, | ||
| DAO: dao, | ||
| ProposalID: 0, // Will be set when proposal is created | ||
| } | ||
|
|
||
| // Create a proposal in the DAO to approve this application | ||
| proposalDef := NewClaimBountyProposal(bountyID, applicationCount, caller, prLink) | ||
|
|
||
| proposal := dao.MustPropose(caller, proposalDef) | ||
| application.ProposalID = proposal.ID() |
There was a problem hiding this comment.
Do the DAO.MustPropose before creating the application structure so you can directly set the proposalId instead of setting it to 0 by default.
Comment on lines
+187
to
+191
| if app.DAO != nil && app.Status == StatusPending { | ||
| if app.DAO.Members().Has(validatorAddr) { | ||
| apps = append(apps, app) | ||
| } | ||
| } |
Comment on lines
+73
to
+80
| for i := 0; i < len(result)-1; i++ { | ||
| for j := 0; j < len(result)-i-1; j++ { | ||
| if result[j].Score < result[j+1].Score { | ||
| // Swap | ||
| result[j], result[j+1] = result[j+1], result[j] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe ask @leohhhn if a bubble sort is already implemented
Comment on lines
+93
to
+116
| output += "| Rank | User | Score | 💰 Bounties | 📝 Applications | ⚖️ Validations |\n" | ||
| output += "|---|---|---|---|---|---|\n" | ||
|
|
||
| for i, entry := range entries { | ||
| rank := "" | ||
| switch i { | ||
| case 0: | ||
| rank = "🥇" | ||
| case 1: | ||
| rank = "🥈" | ||
| case 2: | ||
| rank = "🥉" | ||
| default: | ||
| rank = ufmt.Sprintf("%d", i+1) | ||
| } | ||
|
|
||
| output += ufmt.Sprintf("| %s | %s | **%d** | %d | %d | %d |\n", | ||
| rank, | ||
| entry.Address, | ||
| entry.Score, | ||
| entry.BountiesCreated, | ||
| entry.BountiesApplied, | ||
| entry.ValidationsPerformed, | ||
| ) |
There was a problem hiding this comment.
Maybe use gno.land/p/moul/md to create the table
| // Refund the creator | ||
| bnk := banker.NewBanker(banker.BankerTypeRealmSend) | ||
| send := chain.Coins{chain.Coin{Denom: "ugnot", Amount: bounty.Amount}} | ||
| pkgAddr := chain.PackageAddress("gno.land/r/greg007/gnobounty") |
There was a problem hiding this comment.
Save the package address into a variable so you can change it easily if it's redeployed.
|
|
||
| // Transfer rewards | ||
| bnk := banker.NewBanker(banker.BankerTypeRealmSend) | ||
| pkgAddr := chain.PackageAddress("gno.land/r/greg007/gnobounty") |
Comment on lines
+28
to
+37
| output += "## 🎯 Quick Actions\n\n" | ||
| output += md.Link("👨⚖️ Register as Validator", registerValidatorLink) | ||
| output += " | " | ||
| output += md.Link("💰 Create a new bounty", createBountyLink) | ||
| output += ufmt.Sprintf(" _(minimum reward: %s)_", minSend) | ||
| output += " | " | ||
| output += md.Link("📋 View All Validators", "/r/greg007/gnobounty:validators") | ||
| output += " | " | ||
| output += md.Link("🏆 Leaderboard", "/r/greg007/gnobounty:leaderboard") | ||
| output += "\n\n" |
There was a problem hiding this comment.
same use gno.land/p/moul/md package
| output += " | " | ||
|
|
||
| // Add view details link | ||
| detailsPath := ufmt.Sprintf("/r/greg007/gnobounty:%d", bounty.ID) |
There was a problem hiding this comment.
same, package address into a variable with a setter function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces gnobounty, a decentralized bounty system built on Gno that allows users to place bounties on GitHub issues using cryptocurrency.