Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d5b145cb9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| runtime = {k: definition[k] for k in RUNTIME_FIELDS if k in definition} | ||
| if not runtime or runtime.get("status") == "todo": | ||
| # No runtime state to migrate | ||
| skipped.append(task_id) | ||
| continue |
There was a problem hiding this comment.
In cmd_migrate_state, tasks whose legacy status is todo are skipped entirely (continue) before the --clean block runs. That means flowctl migrate-state --clean leaves runtime fields like status, assignee, etc. in .flow/tasks/*.json for all todo tasks, which contradicts the documented intent of --clean and leaves stale runtime data in tracked files once state moves to .git/flow-state. This shows up when most tasks are still todo—--clean reports success but the JSONs remain polluted.
Useful? React with 👍 / 👎.
1 participant
Summary\n- port runtime state store (flow-state), state-path/migrate-state commands, checkpoint v2\n- include task specs in plan reviews + consistency checks + task-spec sync loop\n- add task set-spec --file and update docs/README/usage\n\n## Testing\n- python3 -m py_compile .opencode/bin/flowctl.py