Allow binding custom events to non-form elements#73
Open
maxpoulin64 wants to merge 1 commit intogmac:masterfrom
Open
Allow binding custom events to non-form elements#73maxpoulin64 wants to merge 1 commit intogmac:masterfrom
maxpoulin64 wants to merge 1 commit intogmac:masterfrom
Conversation
Epoxy previously refused to bind events to non form elements like <div>s so it was impossible to create bindingHandlers for some UI libraries like jQuery UI's "slide" event. This now allows it to still avoid binding useless events while still allowing custom events to be forced in by the user.
Owner
|
Cool, thanks. Out of the country at the moment, I'll try to review in the coming weeks and give the pass/fail/cleanup. |
|
I ran into this issue yesterday, ended up modifying my local copy of epoxy.js, but would like to see this fix merged and deployed to bower if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some UI libraries (like jQuery UI) relies on DOM events to dispatch updates events. An example would be the jQuery UI sliders, which triggers a "slide" event on its containing
Epoxy previously refused to bind events to non form elements like divs so it was impossible to create bindingHandlers using those events. set() was working correctly but get() was never ever called because the events were never bound due to changable being false. I fixed it so when a user manually passes events, they are bound regardless of if it's a form element or not. Passing events on the DOM for custom widgets is not uncommon so I thought I should share the modification =]
(Note: this is my first pull request ever, please excuse my mistakes if any!)