Rule to check hardcoded rightnames#25
Merged
Merged
Conversation
froozeify
requested changes
Jun 16, 2026
froozeify
left a comment
froozeify
left a comment
Member
There was a problem hiding this comment.
Using positional named parms for sprintf
stonebuzz
suggested changes
Jun 16, 2026
stonebuzz
approved these changes
Jun 17, 2026
froozeify
approved these changes
Jun 17, 2026
cedric-anne
requested changes
Jun 17, 2026
cedric-anne
left a comment
cedric-anne
left a comment
Member
There was a problem hiding this comment.
Please add a test class to validate that no error is detected on earlier versions of GLPI. See https://github.com/glpi-project/phpstan-glpi/blob/main/tests/IgnoredGlpiVersion/Rules/ForbidDynamicInstantiationRuleTest.php for example.
cedric-anne
reviewed
Jun 17, 2026
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Benoît VIGNAL <2380113+froozeify@users.noreply.github.com>
missing doc, time lost trying to figure out how it works, I hope it's the attended usage.
SebSept
force-pushed
the
rule-to-check-hardcoded-rightnames
branch
from
0ad9432 to
65abdf4
Compare
cedric-anne
approved these changes
Jun 24, 2026
Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
Contributor
Author
|
sorry for the slop of readme. |
Member
A new release has been published. These new errors will have to be fixed in the next few weeks, before the GLPI 12.0.0 RC1 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A big part was generated using a coding agent.
I reviewed the code.
Tested on a glpi (main branch).
Not tested on a 11/bugfixes branch (rule should not apply).