Conversation
DomFijan
reviewed
Feb 10, 2026
Contributor
Author
|
Note that 46affaf was a big merge containing the 2026 header updates -- I need to make sure I didn't break anything |
Contributor
Author
DomFijan
reviewed
Feb 11, 2026
DomFijan
reviewed
Feb 11, 2026
DomFijan
reviewed
Feb 11, 2026
DomFijan
reviewed
Feb 11, 2026
DomFijan
reviewed
Feb 11, 2026
Contributor
Author
|
@DomFijan Somehow this works only on macOS -- do you get more debug output on your end? |
DomFijan
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a combination rewrite/refactor that aims to (1) replace pybind11 code with nanobind and (2) restructure data types and the code layout to interface better with cymmetry (upcoming library & publication) and new optimizer developments.
The biggest change is a separation of python interfaces from c++ source code -- bindings are consolidated to separate files, and much of the library is now available as headers for use in other tools. The area of the interface is also reduced, with nanobind's ndarray replacing python exports for Vec3 and Quaternion types exported in previous versions. Finally, the data classes (PGOP- and BOOSOPStore) have been removed. These adapters were added in previous versions for performance reasons, but nanobind allows for copy-free array translation that removes this necessity. These changes, combined with a few other optimizations, result in a 400-500% performance increase across the board.
Changed
pgop.py::BOOSOPcode is now in separate fileboosop.py.std::vector<std::vector<...>>are now vectors of pointers, allowing for copy- and move- free access to python data. Matrix elements are accessed withstd::spanand cast to statically-allocated types for performance.py::arrayare now replaced withstd::vectorortype*pointersstd::vector<double>) is nowtypedef RotationMatrix = std::array<double, 9>Removed
Added
m_group_sizesclass method for PGOP, which stores the size of each group (currently, (group order - 1) * 9). Previous code used vector.size, which requires copies and allocations for both individual elements and entire groups.-DENABLE_PROFILINGflag to allow for easy profilingBenchmarking
Before this PR
Compute PGOP for mesh of 600 points, computed for an icosahedron (N=12, N_query=1):
Same approach, just with mode = "boo" and sigma=177.7 (~kappa = 0.075):
After this PR
Compute PGOP for mesh of 600 points, computed for an icosahedron (N=12, N_query=1):
With mode="boo" and the same sigma/kappa conversion
Motivation and Context
Resolves: #???
How Has This Been Tested?
Checklist: