Updation sdk with v3 by pkuma525 · Pull Request #164 · globalpayments/SecureSubmit-woocommerce-plugin

pkuma525 · 2019-10-01T06:24:58Z

updated the code to use the latest php-sdk and updated the readme file regarding the sdk download with composer code. Need to remove " includes" folder from location heartland-woocommerce-plugin/classes/

slogsdon · 2019-10-07T14:11:55Z


-Download the contents and extract to your WordPress plugin folder. Activate.
+Download the contents and extract to your WordPress plugin folder. 
+Open the composer from the plugin directory and run the command "composer require globalpayments/php-sdk". Activate.


We need to ship a copy of the SDK within the plugin itself. WordPress doesn't use / require composer on its own, and the plugin installation process does not have the option for calling composer scripts.

slogsdon · 2019-10-07T14:13:32Z

@@ -439,21 +440,21 @@ protected function getCartDiscountTotal()
    }

    protected function giftCardService()


Let's rename this to giftCardServiceConfig

slogsdon · 2019-10-07T14:14:15Z

+    {       
+        $config = new ServicesConfig();
+        $config->secretApiKey = $this->secret_key;
+        $config->serviceUrl = ($this->enableCryptoUrl) ?


We can scrap the enableCryptoUrl property and only use https://api2.heartlandportico.com and https://cert.api2.heartlandportico.com

slogsdon · 2019-10-07T14:14:39Z

+        $config->secretApiKey = $this->secret_key;
+        $config->serviceUrl = ($this->enableCryptoUrl) ?
+                'https://cert.api2-c.heartlandportico.com/' :
+                'https://cert.api2.heartlandportico.com';


This method needs to handle the different URLs for production and sandbox/certification.

slogsdon · 2019-10-07T14:15:14Z

    {
        // includes
-        require_once 'includes/Hps.php';
+        //require_once 'includes/Hps.php';


Once the SDK is pulled into the plugin, we need to set up an autoloader and require it here in order to load the SDK at runtime.

slogsdon · 2019-10-07T14:17:19Z

-        $config->developerId = '002914';
+        $config->serviceUrl = ($this->enableCryptoUrl) ?
+                'https://cert.api2-c.heartlandportico.com/' :
+                'https://cert.api2.heartlandportico.com';


This method needs to handle the different URLs for production and sandbox/certification.

slogsdon · 2019-10-07T14:19:31Z

+                        $tokenval = $response->token;

-                        if ($response->tokenData->responseCode == '0') {
+                        if ($response->token == '0') {


This expression needs to be updated to check for a non-empty value. The token property will contain the token value, not the tokenization response code.

slogsdon · 2019-10-07T14:20:16Z

-            $chargeService = $this->parent->getCreditService();
+            $this->parent->getCreditService();
+            $transaction = new Transaction();
+            $chargeService = $transaction->fromId($transactionId);


Transaction::fromId is a static method. We should not be calling it in this fashion.

slogsdon · 2019-10-07T14:20:49Z

-            $chargeService = $this->parent->getCreditService();
+            $this->parent->getCreditService();
+            $transaction = new Transaction();
+            $chargeService = $transaction->fromId($transactionId);


Transaction::fromId is a static method. We should not be calling it in this fashion.

slogsdon · 2019-10-07T14:21:42Z

+	$path = dirname(plugin_dir_path(__FILE__));
+        include $path . '/'.basename(__DIR__).'/vendor/autoload.php';
+
+


This should remain where Hps.php is required.

…nd-woocommerce-plugin into updation-sdk-with-v3

slogsdon · 2019-11-04T18:54:21Z

 ## Usage

-Download the contents and extract to your WordPress plugin folder. Activate.
+Download the contents and extract to your WordPress plugin folder. 


They still need to activate the plugin in order to have Heartland as a payment gateway option.

slogsdon · 2019-11-04T18:55:51Z

            foreach ($processed_cards as $card_id => $card) {
                try {
-                    $response = $this->giftCardService()->void($card->transaction_id)
+                    $response = $this->giftCardServiceConfig()->void($card->transaction_id)


Has this been tested yet? It seems an error would be thrown since void doesn't exist on ServicesConfig

slogsdon · 2019-11-04T18:57:01Z

        $transactionId = $this->getOrderTransactionId($order);
-        $transaction = $this->getCreditService()->get($transactionId)->execute();
-        return $transaction->transactionStatus == 'A';
+        $refundservice = $this->getCreditService();


$refundservice doesn't seem to be used here.

slogsdon · 2019-11-04T18:57:32Z

-        return $transaction->transactionStatus == 'A';
+        $refundservice = $this->getCreditService();
+        $reportingService = new ReportingService();
+        $transactions = $reportingService->transactionDetail($transactionId)->execute();


ReportingService::transactionDetail is a static method. It shouldn't be called as an instance method.

pkuma525 added 5 commits July 3, 2019 00:42

Updated Changes in capture,authorize,verify,refund and reverse

fe0135d

gift payemnt changes

ee6719d

Added and updated the gift card using new sdk

a9abf4b

updated the code with 3d secure

840c0db

updated the readme file about the vendor installation

6c497d4

pkuma525 requested a review from slogsdon October 1, 2019 06:24

slogsdon requested changes Oct 7, 2019

View reviewed changes

pkuma525 and others added 3 commits October 11, 2019 05:44

Update README.md

c466f9f

updated the code on the review comments

15e207f

Merge branch 'updation-sdk-with-v3' of https://github.com/hps/heartla…

1ab5b33

…nd-woocommerce-plugin into updation-sdk-with-v3

pkuma525 requested a review from slogsdon October 11, 2019 14:30

updated the code for service url

98486a3

slogsdon requested changes Nov 4, 2019

View reviewed changes

pkuma525 and others added 2 commits November 12, 2019 02:07

Merge branch 'master' into updation-sdk-with-v3

3e144c8

updated the code as per review

111df16

pkuma525 requested a review from slogsdon November 12, 2019 10:45

		@@ -439,21 +440,21 @@ protected function getCartDiscountTotal()
		}

		protected function giftCardService()

		$path = dirname(plugin_dir_path(__FILE__));
		include $path . '/'.basename(__DIR__).'/vendor/autoload.php';

Conversation

pkuma525 commented Oct 1, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants