Update p3 d types with reflector depth #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ceiling recessed cylinder
update round recessed
update using reflector depth
update open luminaire
Member
|
Die Überarbeitung weicht vom Stil der Seite ab. Alle Wörter, die Elementen in XML entsprechen, sind in der Doku besonders hervorgehoben. Wir sollten weiterhin einen einheitlichen Stil pflegen: Bisher, richtig: Jetzt |
Member
|
Das Bild passt nicht mehr zu den Parametern |
update xml samples and images
update style
Kurpanik
approved these changes
Nov 22, 2024
Member
|
@alexrelux Du arbeitest noch an dem PR? Er ist im Draft Modus |
Contributor
Author
|
Ja, das Team muss noch Änderungen umsetzen. Solange sich das verzögert, sollten wir die Veröffentlichung zurückhalten. |
Member
|
Alles klar |
Contributor
Author
|
@Kurpanik Hi Alex, so wurde das jetzt implementiert. Gruss Alex |
Member
|
@alexrelux Der PR ist noch im Draft. Sprich die Doku ist jetzt aber noch nicht fertig? |
Contributor
Author
|
ist fertig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update p3 d types with reflector depth