fix: filter trimmed module references#18
Merged
thegdsks merged 2 commits intoglincker:masterfrom Apr 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
depends_onanddepended_byto the retained module set whenmax_modulestrims the graphmost_dependedandisolatedfrom the retained modules so the generated index stays internally consistentRoot cause
assembleIndex()capped themodulesmap, but it still copied dependency metadata from the full graph. That could leavestacklit.jsonwith dangling module references inmodules.*.depends_on,modules.*.depended_by,dependencies.edges, anddependencies.most_depended.Impact
With
max_modulesset below the full module count, Stacklit could emit an index where dependency edges point to modules that are no longer present inmodules. That can mislead AI consumers and produce Mermaid edges to undefined nodes.Validation
gofmt -w internal/engine/engine.go internal/engine/engine_test.gogo test ./...go build -o stacklit.exe ./cmd/stacklit./stacklit.exe init