Skip to content

fix: run stacklit action on push to master, not PRs#16

Merged
thegdsks merged 1 commit intomasterfrom
fix/stacklit-action-workflow
Apr 13, 2026
Merged

fix: run stacklit action on push to master, not PRs#16
thegdsks merged 1 commit intomasterfrom
fix/stacklit-action-workflow

Conversation

@thegdsks
Copy link
Copy Markdown
Member

Summary

  • Change stacklit-index workflow from check mode on PRs to auto-commit mode on push to master
  • Check mode on PRs breaks because contributors don't regenerate the index before pushing

What changes

  • Trigger: pull_requestpush to master
  • Mode: checkauto-commit
  • Added permissions: contents: write for auto-commit

Copilot AI review requested due to automatic review settings April 13, 2026 00:48
@thegdsks thegdsks merged commit c8da785 into master Apr 13, 2026
3 checks passed
@thegdsks thegdsks self-assigned this Apr 13, 2026
@thegdsks thegdsks added the performance Speed or memory improvements label Apr 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Stacklit index GitHub Actions workflow so the index is regenerated and committed automatically on pushes to master, rather than running in “check” mode on pull requests.

Changes:

  • Switch workflow trigger from pull_request to push on master.
  • Change Stacklit action mode from check to auto-commit.
  • Grant contents: write permission to allow committing updates back to the repo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +4 to 7
branches: [master]

jobs:
stacklit:
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this workflow auto-commits, the resulting push to the same branch will re-trigger the workflow (at least once). To avoid redundant runs (and prevent potential loops if generated files vary), add paths-ignore for the generated outputs (e.g., stacklit.json and DEPENDENCIES.md) and/or guard with an if: that skips when the actor is the bot doing the commit.

Suggested change
branches: [master]
jobs:
stacklit:
branches: [master]
paths-ignore:
- stacklit.json
- DEPENDENCIES.md
jobs:
stacklit:
if: github.actor != 'github-actions[bot]'

Copilot uses AI. Check for mistakes.
on:
pull_request:
push:
branches: [master]
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow triggers only on master, but other workflows in this repo run on both master and main. If main is still used (or becomes the default branch), this index updater will stop running; consider including both branches ([master, main]) for consistency.

Suggested change
branches: [master]
branches: [master, main]

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Speed or memory improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants