-
Notifications
You must be signed in to change notification settings - Fork 4
fix: make generated outputs deterministic #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thegdsks
merged 2 commits into
glincker:master
from
aayushprsingh:fix/deterministic-output-writes
Apr 12, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| package renderer | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "os" | ||
|
|
||
| "github.com/glincker/stacklit/internal/schema" | ||
| ) | ||
|
|
||
| func normalizedIndexJSON(idx *schema.Index) ([]byte, error) { | ||
| clone := *idx | ||
| clone.GeneratedAt = "" | ||
| return json.Marshal(clone) | ||
| } | ||
|
|
||
| // preserveGeneratedAtIfUnchanged keeps the previous GeneratedAt value when the | ||
| // semantic index content is unchanged. This avoids needless output churn across | ||
| // repeated runs, especially on Windows where unchanged locked files should not | ||
| // trigger rewrite attempts. | ||
| func preserveGeneratedAtIfUnchanged(idx *schema.Index, path string) { | ||
| existingBytes, err := os.ReadFile(path) | ||
| if err != nil { | ||
| return | ||
| } | ||
| var existing schema.Index | ||
| if err := json.Unmarshal(existingBytes, &existing); err != nil { | ||
| return | ||
| } | ||
| currentNorm, err := normalizedIndexJSON(idx) | ||
| if err != nil { | ||
| return | ||
| } | ||
| existingNorm, err := normalizedIndexJSON(&existing) | ||
| if err != nil { | ||
| return | ||
| } | ||
| if string(currentNorm) == string(existingNorm) { | ||
| idx.GeneratedAt = existing.GeneratedAt | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff command now loads config to compute scan ignore patterns, but it still reads the index from a hard-coded
stacklit.json. If a user overridesoutput.jsonin.stacklitrc.json,stacklit diffwill read the wrong file or fail. Consider usingcfg.Output.JSON(joined to the same root as the scan) for the initial read and error message to keep diff consistent with configured outputs.