Fix Windows build with conditional Unix-specific code#11
Merged
Conversation
The code was using std::os::unix::fs::PermissionsExt and set_mode() which are only available on Unix. Wrapped these in #[cfg(unix)] attributes so the code compiles on Windows while still setting executable permissions on Unix systems. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed Windows build failure by making Unix-specific file permissions conditional. The code was using
std::os::unix::fs::PermissionsExtandset_mode()which are only available on Unix systems. These are now wrapped in#[cfg(unix)]attributes.Changes
PermissionsExtchmod +xcode in#[cfg(unix)]block so it only runs on Unix systemsTesting
All 39 tests pass. The build now succeeds on Windows while still setting executable permissions on Unix systems.
🤖 Generated with Claude Code