Open
Conversation
Upgrades from 2.0.16 to 2.2.0 to support all 316 icons available on heroicons.com. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
@jassmith Are you willing and able to approve this package update so heroicon offers all the latest icons? |
Author
|
PS - not sure what to do about the Vercel failure. |
ivoelbert
requested changes
Apr 9, 2026
Contributor
ivoelbert
left a comment
ivoelbert
left a comment
There was a problem hiding this comment.
The lock file change is not fine. You probably installed things with the wrong node version. Sadly I have no idea which node version you should use 😆
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel-at-glide
requested review from
ivoelbert
and removed request for
jassmith
ivoelbert
approved these changes
Apr 9, 2026
Contributor
ivoelbert
left a comment
ivoelbert
left a comment
There was a problem hiding this comment.
I guess this should be fine??? not really sure how to test properly
Author
|
@ivoelbert Here's the testing answer: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@heroicons/reactfrom2.0.16to2.2.0package-lock.jsondiff is a one-time npm lockfile format migration (v1 legacy → v2 format), not new packages being installedTest plan
npm testto verify heroicons column tests passnpm run devand manually test a few icons that were previously missing🤖 Generated with Claude Code