fix(watcher): store Debouncer in RepoWatcher to prevent OS handle leak#2978
Open
Noethix55555 wants to merge 1 commit into
Open
fix(watcher): store Debouncer in RepoWatcher to prevent OS handle leak#2978Noethix55555 wants to merge 1 commit into
Noethix55555 wants to merge 1 commit into
Conversation
`create_watcher` called `std::mem::forget(bouncer)` to keep the file-watcher alive, but this permanently leaked the OS watcher handle on every call. Each submodule repo opened added another leaked handle that was never cleaned up. Fix: remove `create_watcher` and the spawned thread that called it. Create the debouncer inline in `RepoWatcher::new` and store it in a new `_watcher` field so the OS handle is released when `RepoWatcher` is dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_watchercalledstd::mem::forget(bouncer)to keep the OS file-watcher handle alive, but this permanently leaks the handle on every call — one leak per submodule repo opened, never cleaned up.create_watcher(and the thread that called it). Create theDebouncerinline inRepoWatcher::newand store it in a new_watcher: Debouncer<RecommendedWatcher>field so the OS handle is properly released whenRepoWatcheris dropped.scopetimeimport.Test plan
lsof/Process Explorer) when opening multiple repos