Skip to content

fix: actually truncate over-long commit messages and submodule paths in lists#2971

Open
Noethix55555 wants to merge 1 commit into
gitui-org:masterfrom
Noethix55555:fix/list-truncation
Open

fix: actually truncate over-long commit messages and submodule paths in lists#2971
Noethix55555 wants to merge 1 commit into
gitui-org:masterfrom
Noethix55555:fix/list-truncation

Conversation

@Noethix55555

Copy link
Copy Markdown

In branchlist.rs and submodules.rs, the calls to .unicode_truncate(...) return the truncated string slice, but the return value is discarded. As a result the original untruncated string is kept and only "..." is appended, making the displayed entry longer than the available width.

The adjacent branch_name truncation in branchlist.rs already does this correctly (.unicode_truncate(...).0.to_string()). Applied the same pattern to commit_message in branchlist.rs and module_path in submodules.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant